[PATCH] D17606: [PPC64] Bug fix: when enable both sibling-call-opt and shrink-wrapping, the tail call branch instruction might disappear

[Kit Barton via llvm-commits]

kbarton added a comment.

Aside from the minor point about the comment, this LGTM.


================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:1325
@@ +1324,3 @@
+void PPCFrameLowering::createTailCallBranchInstr(MachineBasicBlock &MBB) const {
+  // Same code from emitEpilogue
+  MachineBasicBlock::iterator MBBI = MBB.getFirstTerminator();
----------------
This comment isn't accurate since you've refactored the code from emitEpilogue into this method. 
You could probably remove it altogether, but if you want to keep it I could change it to "Originally from emitEpilogue". 


http://reviews.llvm.org/D17606