[PATCH] D18586: Allow DeadStoreElimination to track combinations of partial later wrties

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 31 09:43:56 PDT 2016


hfinkel added inline comments.

================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:442
@@ +441,3 @@
+  if (EnablePartialOverwriteTracking &&
+      LaterOff < int64_t(EarlierOff + Earlier.Size) &&
+      int64_t(LaterOff + Later.Size) >= EarlierOff) {
----------------
mcrosier wrote:
> Should this be <= rather than <?
I don't think so. If LaterOff == EarlierOff + Earlier.Size, then it is starting on the byte after the earlier one ends.


http://reviews.llvm.org/D18586





More information about the llvm-commits mailing list