[PATCH] D18586: Allow DeadStoreElimination to track combinations of partial later wrties

[Chad Rosier via llvm-commits]

mcrosier added a comment.

Looks reasonable to me, but you may want to wait for additional reviews.  Comments/questions inline.


================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:440
@@ +439,3 @@
+  // Note: The correctness of this logic depends on the fact that this function
+  // is not even called providing DepWrite when there are any intervening reads.
+  if (EnablePartialOverwriteTracking &&
----------------
not even -> never

================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:442
@@ +441,3 @@
+  if (EnablePartialOverwriteTracking &&
+      LaterOff < int64_t(EarlierOff + Earlier.Size) &&
+      int64_t(LaterOff + Later.Size) >= EarlierOff) {
----------------
Should this be <= rather than <?


http://reviews.llvm.org/D18586