[PATCH] D17533: CXX_FAST_TLS calling convention: performance improvement for PPC64

Kit Barton via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 30 10:34:45 PDT 2016


kbarton added a comment.

Please add more info in the summary about what this is, and why it is necessary. 
Also, if you could include a link to the Phabricator review for the AArch64 review that would be very helpful for people who are reviewing this through a browser.


================
Comment at: lib/CodeGen/TargetFrameLoweringImpl.cpp:66
@@ -65,1 +65,3 @@
 
+  SavedRegs.resize(TRI.getNumRegs());
+
----------------
Please add a comment here about why this is necessary to do before the early return.
This will (hopefully) ensure this doesn't get moved below the return and introduce a problem again.


http://reviews.llvm.org/D17533





More information about the llvm-commits mailing list