[PATCH] D18570: [AArch64] Handle missing store pair opportunity

[Chad Rosier via llvm-commits]

mcrosier accepted this revision.
mcrosier added a comment.
This revision is now accepted and ready to land.

LGTM, with a few minor nits.


================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1608
@@ -1607,3 +1607,3 @@
   MachineBasicBlock::iterator MergeMI =
-      findMatchingInsn(MBBI, Flags, LdStLimit);
+      findMatchingInsn(MBBI, Flags, LdStLimit, true);
   if (MergeMI != E) {
----------------
I tend to add a comment next to boolean arguments (e.g., "/*FindNarrowMerge=*/ true").

================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1644
@@ -1644,1 +1643,3 @@
+  MachineBasicBlock::iterator Paired =
+      findMatchingInsn(MBBI, Flags, LdStLimit, false);
   if (Paired != E) {
----------------
/*FindNarrowMerge=*/ false

================
Comment at: test/CodeGen/AArch64/arm64-narrow-ldst-merge.ll:356
@@ -355,3 +355,3 @@
 
 ;CHECK-LABEL: Strw_zero
 ;CHECK : str xzr
----------------
Please put a space between the semicolon and the CHECK directive.  Also, please remove the space between the CHECK directive and the colon below.  I'm not sure if FileCheck considers "CHECK :" as a directive.

================
Comment at: test/CodeGen/AArch64/arm64-narrow-ldst-merge.ll:370
@@ -369,1 +369,3 @@
 
+;CHECK-LABEL: Strw_zero_nonzero
+;CHECK : stp wzr, w1
----------------
Please put a space between the semicolon and the CHECK directive.

================
Comment at: test/CodeGen/AArch64/arm64-narrow-ldst-merge.ll:384
@@ -370,2 +383,3 @@
+
 ;CHECK-LABEL: Strw_zero_4
 ;CHECK : stp xzr
----------------
Please put a space between the semicolon and the CHECK directive.


http://reviews.llvm.org/D18570