[PATCH] D17776: Improve CHECK-NOT robustness of dllimport/dllexport tests

[Warren Ristow via llvm-commits]

wristow added a comment.

Thanks Sean.  The `-NOT/-SAME` issue was my main goal, but I threw in new coverage for some edge cases and that's completely independent, as you said.  I'll separate that out.

The camelCase changes are //partially// intertwined with the `-NOT/-SAME` issue, in that the test as it stands defines (for example) a function named `notExported()` and then the `-NOT/-SAME` checks mistakenly check for the name `not_exported`.  So unless the camelCase issue is fixed, a fix for the `-NOT/-SAME` portion isn't effective.  In any case, fixing the camelCase independently (prior to the `-NOT/-SAME` fix) will make things clearer, I agree.  I've just separated the camelCase aspect out at http://reviews.llvm.org/D18589.  I'll update this review after that one  is wrapped up.


http://reviews.llvm.org/D17776