[PATCH] D17776: Improve CHECK-NOT robustness of dllimport/dllexport tests

[Sean Silva via llvm-commits]

silvas added a comment.

It looks like you have at least 3 independent patches here:

- fixing confusion between `-NOT` and `-SAME`
- renaming some names to camelCase
- addng new coverage for some edge cases

It would be easier to review this if you split it up.


================
Comment at: llvm/test/CodeGen/X86/dllexport-x86_64.ll:88
@@ +87,3 @@
+; be exported.
+ at exportedButNotDefinedVariable = external dllexport global i32
+declare dllexport void @exportedButNotDefinedFunction()
----------------
This looks like it is actually trying to add new test coverage. Please split that into a separate patch.

================
Comment at: llvm/test/CodeGen/X86/dllexport.ll:31
@@ -23,3 +30,3 @@
 
-declare dllexport void @not_defined()
+declare dllexport void @notDefined()
 
----------------
Please avoid renaming this. You can do that in a separate clean-up.

================
Comment at: llvm/test/CodeGen/X86/dllexport.ll:98
@@ -90,1 +97,3 @@
 
+; Verify items that should not be exported do not appear in the export table.
+; NOTEXPORTED: .section .drectve
----------------
Maybe say something like "we use a separate check prefix to avoid confusion between -NOT and -SAME". Same in the other test.


http://reviews.llvm.org/D17776