[PATCH] D18468: Profile summary cleanup.
Dehao Chen via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 28 09:38:48 PDT 2016
danielcdh added inline comments.
================
Comment at: include/llvm/ProfileData/ProfileCommon.h:153
@@ -153,4 +152,3 @@
uint64_t getTotalSamples() { return TotalCount; }
- uint32_t getNumFunctions() { return NumFunctions; }
- uint64_t getMaxHeadSamples() { return MaxHeadSamples; }
+ uint64_t getMaxHeadSamples() { return MaxFunctionCount; }
uint64_t getMaxSamplesPerLine() { return MaxCount; }
----------------
dnovillo wrote:
> Perhaps we should deprecate getMaxHeadSamples? IIUC, MaxFunctionCount is the number of times a function was called, correct? That's essentially the same information provided by counting the number of samples in the function header.
>
> There is a difference between the two, but I don't think the distinction is worth keeping. Dehao, what do you think?
Agree, MaxHeadSamples should be the same as MaxFunctionCount.
http://reviews.llvm.org/D18468
More information about the llvm-commits
mailing list