[PATCH] D18468: Profile summary cleanup.

[Diego Novillo via llvm-commits]

dnovillo accepted this revision.
dnovillo added a comment.

LGTM


================
Comment at: include/llvm/ProfileData/ProfileCommon.h:153
@@ -153,4 +152,3 @@
   uint64_t getTotalSamples() { return TotalCount; }
-  uint32_t getNumFunctions() { return NumFunctions; }
-  uint64_t getMaxHeadSamples() { return MaxHeadSamples; }
+  uint64_t getMaxHeadSamples() { return MaxFunctionCount; }
   uint64_t getMaxSamplesPerLine() { return MaxCount; }
----------------
Perhaps we should deprecate getMaxHeadSamples?  IIUC, MaxFunctionCount is the number of times a function was called, correct?  That's essentially the same information provided by counting the number of samples in the function header.

There is a difference between the two, but I don't think the distinction is worth keeping.  Dehao, what do you think?


http://reviews.llvm.org/D18468