[PATCH] D18332: [ELF/AArch64] Add GD to IE TLS relax optimization
Adhemerval Zanella via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 21 15:38:42 PDT 2016
zatrazz added a comment.
Thanks for the review.
================
Comment at: ELF/Target.cpp:1606
@@ +1605,3 @@
+ default:
+ llvm_unreachable("Unsupported relocation for TLS GD to IE relaxation");
+ }
----------------
grimar wrote:
> lowercase please:
> llvm_unreachable("unsupported relocation for TLS GD to IE relaxation");
I will change that.
================
Comment at: test/ELF/aarch64-tls-gdie.s:18
@@ +17,3 @@
+# CHECK: _start:
+# CHECK: 11000: 00 00 00 b0 adrp x0, #4096
+# CHECK: 11004: 00 58 40 f9 ldr x0, [x0, #176]
----------------
grimar wrote:
> I think you want to use CHECK-NEXT below
I will change that.
Repository:
rL LLVM
http://reviews.llvm.org/D18332
More information about the llvm-commits
mailing list