[PATCH] D18332: [ELF/AArch64] Add GD to IE TLS relax optimization

[George Rimar via llvm-commits]

grimar added a comment.

My review will not be very helpfull here. Just minors.


================
Comment at: ELF/Target.cpp:1606
@@ +1605,3 @@
+  default:
+    llvm_unreachable("Unsupported relocation for TLS GD to IE relaxation");
+  }
----------------
lowercase please:
llvm_unreachable("unsupported relocation for TLS GD to IE relaxation");

================
Comment at: test/ELF/aarch64-tls-gdie.s:18
@@ +17,3 @@
+# CHECK: _start:
+# CHECK:  11000:	00 00 00 b0	adrp    x0, #4096
+# CHECK:  11004:	00 58 40 f9 	ldr     x0, [x0, #176]
----------------
I think you want to use CHECK-NEXT below


Repository:
  rL LLVM

http://reviews.llvm.org/D18332