[PATCH] D18183: [ELF] - -pie/--pic-executable option implemented
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 16 13:51:04 PDT 2016
ruiu added a comment.
LGTM
================
Comment at: test/ELF/undef.s:3-4
@@ -2,3 +2,4 @@
# RUN: not ld.lld %t -o %t2 2>&1 | FileCheck %s
# CHECK: undefined symbol: bar in {{.*}}
# CHECK: undefined symbol: foo in {{.*}}
+# RUN: not ld.lld -pie %t -o %t2 2>&1 | FileCheck %s
----------------
Move CHECK after the following RUN. (Basically, we want to keep the source code not being "patchy". New code should look as if it were there from beginning. I don't think you wrote this way if you have written these two RUN lines)
http://reviews.llvm.org/D18183
More information about the llvm-commits
mailing list