[PATCH] D18183: [ELF] - -pie/--pic-executable option implemented

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 13:48:35 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/Options.td:102
@@ -100,1 +101,3 @@
+  HelpText<"Create a position independent executable">;
+
 def print_gc_sections: Flag<["--"], "print-gc-sections">,
----------------
grimar wrote:
> btw, not about this patch, but in general.
> If we have errors/warnings in lowercase. Do we want HelpText here to be lowercase as well ? I guess yes.
I don't know which is better, but this is where we just want to follow the convention. What do other command do for --help?


http://reviews.llvm.org/D18183





More information about the llvm-commits mailing list