[PATCH] D18164: [tsan] Do not instrument reads/writes to instruction profile counters.

Tue Mar 15 10:36:15 PDT 2016

On Tue, Mar 15, 2016 at 10:25 AM, Anna Zaks <zaks.anna at gmail.com> wrote:

> zaks.anna added a comment.
>
> How about we mark that load as "Monotonic"?
>

No -- tsan warning should not be the right motivation for this kind of
change.  If this helps improving instrumentation runtime performance or
profile data precision, then it is a different story.

A related question -- why is it useful to turn on tsan for profile
instrumented build? What addition user errors does it try to catch?

David

>
> Is the profiler team OK with that? My understanding is that you did not
> want anything that causes run time overhead on x86 and ARM. In any case,
> that would allow us to unblock TSan and give you time to decide what you
> want to do.
>
>
> http://reviews.llvm.org/D18164
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160315/0cf9a3d8/attachment.html>