[PATCH] D17992: Materialize metadata in IRLinker before value mapping

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 16:19:57 PST 2016


On 9 March 2016 at 13:50, Teresa Johnson <tejohnson at google.com> wrote:
> tejohnson added a comment.
>
> In http://reviews.llvm.org/D17992#370876, @rafael wrote:
>
>> It hides the fact that the metadata is actually read eagerly.
>>  Cheers,
>> Rafael
>
>
> Not sure I follow - when metadata is read eagarly (ShouldLazyLoadMetadata=false), this will be a nop.
>
> If by "actually read eagerly" you are referring to the fact that metadata parsing is still all-or-nothing, I don't see how this patch really hides or affects that.

Sorry,  you are right. I was thinking about "all or nothing", but that
is independent.

LGTM

Cheers,
Rafael


More information about the llvm-commits mailing list