[PATCH] D17992: Materialize metadata in IRLinker before value mapping

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In http://reviews.llvm.org/D17992#370876, @rafael wrote:

> It hides the fact that the metadata is actually read eagerly.
>  Cheers,
> Rafael


Not sure I follow - when metadata is read eagarly (ShouldLazyLoadMetadata=false), this will be a nop.

If by "actually read eagerly" you are referring to the fact that metadata parsing is still all-or-nothing, I don't see how this patch really hides or affects that.

I'm not hugely wedded to this patch, but just want to understand why it would be a bad thing, since it would seem to make bitcode reading clients simpler.


http://reviews.llvm.org/D17992