[PATCH] D17066: libLTO: add a ThinLTOCodeGenerator on the model of LTOCodeGenerator.

[Yunzhong Gao via llvm-commits]

ygao added inline comments.

================
Comment at: include/llvm-c/lto.h:699
@@ +698,3 @@
+ * Test if a module has support for ThinLTO linking.
+ */
+extern bool lto_module_is_thinlto(lto_module_t mod);
----------------
This, and the two functions that ensue, may also need to say LTO_API_VERSION=18?
I think it is more natural to say "a list of global symbols" than "a list of all global symbols", but English is not my first language.

================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:1
@@ +1,2 @@
+//===-ThinLTOCodeGenerator.cpp - LLVM Link Time Optimizer -----------------===//
+//
----------------
This is probably copied from LTOCodeGenerator.cpp. Can you confirm that the summary line is accurate?

================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:44
@@ +43,3 @@
+#include <unordered_map>
+#include <unordered_set>
+
----------------
Do you need unordered_set here? I did not see unordered_set being used in this file.


http://reviews.llvm.org/D17066