[PATCH] D17066: libLTO: add a ThinLTOCodeGenerator on the model of LTOCodeGenerator.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 7 10:01:47 PST 2016


joker.eph added a comment.

Adding Sergei as a reviewer as he expressed interest in the past.


================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:150
@@ +149,3 @@
+    // User asked to save temps, let dump the bitcode file after import.
+    auto SaveTempPath = SaveTempsDir + llvm::utostr(count) + ".imported.bc";
+    std::error_code EC;
----------------
tejohnson wrote:
> This will be hard to correlate with the original file. How about using some part of the source file name saved in the module here and in the later opt.bc dump? I.e. use the base name of the path returned by getSourceFileName(), but still add in 'count' to avoid conflicts when the same file name is used at multiple paths.
The problem is that with static library, the name is funky. We need to replace parentheses and other special character with something like underscore.


http://reviews.llvm.org/D17066





More information about the llvm-commits mailing list