[PATCH] D17918: [ELF] - Issue an error if trying to generate relocatable from objects having mixed splitstacks.

[Filipe Cabecinhas via llvm-commits]

filcab added a subscriber: filcab.
filcab added a comment.

In http://reviews.llvm.org/D17918#368701, @grimar wrote:

> > You want to also keep ".note.GNU-no-split-stack", no?
>
>
>
>
> > Thank you,
>
> > 
>
> >   Filipe
>
>
> I think I got what you mean, I am not proccessing the ".note.GNU-no-split-stack" at all. So it should not be discarded now then anyways.
>
> George.


It should still get the same type of handling as GNU-split-stack, though. I see no reason to handle one (even if "handle" is discarding if the output is not relocatable) but not the other.

But I think the latter messages have a better idea: Simply rejecting split-stack objects (unless you plan on adding the rest of the support, including changing function prologues) seems like the most appropriate thing to do right now.


http://reviews.llvm.org/D17918