[PATCH] D17918: [ELF] - Issue an error if trying to generate relocatable from objects having mixed splitstacks.

[George Rimar via llvm-commits]

grimar added a comment.

In http://reviews.llvm.org/D17918#368733, @ruiu wrote:

> This patch covers a tricky use case. Is this actually needed? I mean if you want to do something for the split stack, why don't you support it in the linker instead of rejecting it?


I am not sure how many people are using splitstacks (feature itself looks interesting for me though). 
If you think it is reasonable to support it in lld - I can try to do that (and that patch is anyways will be required for -r then).

Leaving behind known silently broken output is anyways bad. 
But you right that use case is a but tricky, so in case we are not planning to support splitstacks we probably can simplify your solution:
just error out if we see any splitstack note in files.

Actually main point of this patch was that I prepared a serie of patches last days that had aim to improve the -r support. 
That was the last one possible major issue I knew about about -r.
It is mentioned in "implementation steps" for -r here https://gcc.gnu.org/wiki/SplitStacks.

George.


http://reviews.llvm.org/D17918