[PATCH] D17652: [CGP] Duplicate addressing computation in cold paths if required to sink addressing mode

[Mehdi Amini via llvm-commits]

> On Mar 4, 2016, at 2:29 PM, Philip Reames <listmail at philipreames.com> wrote:
> 
> reames added inline comments.
> 
> ================
> Comment at: test/Transforms/CodeGenPrepare/X86/sink-addrmode.ll:10
> @@ +9,3 @@
> +; CHECK-LABEL: @test1
> +; CHECK: add i64 %sunkaddr, 40
> +entry:
> ----------------
> joker.eph wrote:
>> (I know you didn't create, but) having named value should be avoided for optimized build, we should fix CGP. Adding tests that relies on the named value is making it harder to fix this.
> Huh?  This is the first I've heard of this advice.  Named values are widespread in the optimizer.  

Any optimization that is using the IRBuilder won't introduce named value in optimized build.

> If we want to change that, it's definitely a separate change.

I don't ask you to change CGP to not emit a named value. I am asking the test not to rely on them.


-- 
Mehdi