[PATCH] D17652: [CGP] Duplicate addressing computation in cold paths if required to sink addressing mode
Philip Reames via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 4 14:29:04 PST 2016
reames added inline comments.
================
Comment at: test/Transforms/CodeGenPrepare/X86/sink-addrmode.ll:10
@@ +9,3 @@
+; CHECK-LABEL: @test1
+; CHECK: add i64 %sunkaddr, 40
+entry:
----------------
joker.eph wrote:
> (I know you didn't create, but) having named value should be avoided for optimized build, we should fix CGP. Adding tests that relies on the named value is making it harder to fix this.
Huh? This is the first I've heard of this advice. Named values are widespread in the optimizer. If we want to change that, it's definitely a separate change.
http://reviews.llvm.org/D17652
More information about the llvm-commits
mailing list