[PATCH] D17830: [MBP] Avoid placing random blocks between loop preheader and header

[Cong Hou via llvm-commits]

congh added inline comments.

================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:210
@@ -209,3 +209,3 @@
   /// in-loop predecessors of this chain.
   unsigned LoopPredecessors;
 };
----------------
reames wrote:
> congh wrote:
> > chandlerc wrote:
> > > reames wrote:
> > > > As a side note, the name of this variable is highly misleading.  When scheduling function chains, this is used to track unscheduled predecessors outside of any loop.  Once this change is in, I'd like to rename this to something more meaningful.  Any suggestions?
> > > No real idea. =/ I agree, it was bad when it started and it has gotten worse.
> > Maybe ChainPredecessors? But in loops this may also be misleading. If we treat the function as a loop body, maybe ChainPredecessorsInLoop is better?
> How does UnscheduledPredecessors sound?  I'm going for something that describes how the value changes over time and what that actually means.  
Sounds good!


Repository:
  rL LLVM

http://reviews.llvm.org/D17830