[PATCH] D17144: [AMDGPU] add AMDGPU target support to ELFObjectFile.h header

[Nikolay Haustov via llvm-commits]

nhaustov added a comment.

> Can you fix it and then add code to LLVM? Adding code to LLVM allows people

>  to start creating object files in the odd "ELF" format. If a fix is not

>  made in a timely manner, it can be too late, and there's a chance that you

>  will have no choice other than supporting the old broken format.


Is the concern more about custom non-standard code in lld for AMDGPU? We are now actively working on making it more standard.

This change is more about general support in LLVM for EM_AMDGPU and allows us to run llvm-objdump on AMDGPU ELFs to verify changes in disassembler. EM_AMDGPU is officially registered too, see http://www.sco.com/developers/gabi/latest/ch4.eheader.html

Assuming we work on removing non-standard code from lld, is there anything wrong with this change?


http://reviews.llvm.org/D17144