[PATCH] D17144: [AMDGPU] add AMDGPU target support to ELFObjectFile.h header

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 1 14:32:07 PST 2016


Can you fix it and then add code to LLVM? Adding code to LLVM allows people
to start creating object files in the odd "ELF" format. If a fix is not
made in a timely manner, it can be too late, and there's a chance that you
will have no choice other than supporting the old broken format.

On Tue, Mar 1, 2016 at 11:23 AM, Matt Arsenault <Matthew.Arsenault at amd.com>
wrote:

> arsenm added a comment.
>
> In http://reviews.llvm.org/D17144#365490, @ruiu wrote:
>
> > I agree with Rafael. Some fields of the AMDGPU ELF file were defined
> based on a misunderstanding of the ELF file format. Please please fix it
> before it's too late.
>
>
> What's currently implemented now is a 1st draft of the spec.Soon a newer
> version will be implemented which I'm pretty sure fixes this issue
>
>
> http://reviews.llvm.org/D17144
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160301/3a872626/attachment.html>


More information about the llvm-commits mailing list