[llvm] r262455 - Bug 20810: Use report_fatal_error instead of unreachable

[Matt Arsenault via llvm-commits]

> On Mar 1, 2016, at 20:47, David Blaikie <dblaikie at gmail.com> wrote:
> 
> 
> 
> On Tue, Mar 1, 2016 at 8:40 PM, Matt Arsenault <arsenm2 at gmail.com <mailto:arsenm2 at gmail.com>> wrote:
> 
> > On Mar 1, 2016, at 20:30, David Blaikie via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> >
> > Test cases?
> 
> These are essentially asserts. Every one of these would be a bug. This pass is very buggy and we don’t want to truly crash if these are hit.
> 
> That seems problematic. Presumably this shouldn't be enabled for end users (just for developers) if it's that bad, and we could just crash/assert-fail/unreachable-fail for developers, perhaps?
> 
> - Dave

This makes the bug reports nicer. At this point we’re just sort of accepting any bugs in this pass as the status quo. R600 support is being minimally maintained and used now. It’s not used by graphics in mesa by default, and it seems to have a limited number of compute users.

-Matt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160301/444f998d/attachment.html>