[llvm] r262455 - Bug 20810: Use report_fatal_error instead of unreachable

Tue Mar 1 20:59:57 PST 2016

On Tue, Mar 1, 2016 at 8:47 PM, David Blaikie via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
>
> On Tue, Mar 1, 2016 at 8:40 PM, Matt Arsenault <arsenm2 at gmail.com> wrote:
>
>>
>> > On Mar 1, 2016, at 20:30, David Blaikie via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>> >
>> > Test cases?
>>
>> These are essentially asserts. Every one of these would be a bug. This
>> pass is very buggy and we don’t want to truly crash if these are hit.
>>
>
> That seems problematic. Presumably this shouldn't be enabled for end users
> (just for developers) if it's that bad, and we could just
> crash/assert-fail/unreachable-fail for developers, perhaps?
>

If the pass has some known instabilities (that presumably don't have
obvious test cases), it might help diagnose if this comes up in production,
vs running off the end of an unreachable. Obviously, this situation is
hopefully temporary.

-- Sean Silva

>
> - Dave
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160301/a7163b03/attachment.html>