[PATCH] D17665: Fix LLD tests that used CHECK-NEXT-NOT

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 27 17:39:19 PST 2016


Lgtm
On Feb 26, 2016 7:32 PM, "Paul Robinson" <Paul_Robinson at playstation.sony.com>
wrote:

> probinson created this revision.
> probinson added a reviewer: grimar.
> probinson added subscribers: rafael, llvm-commits.
>
> FileCheck does not support combined suffixes.
>
> http://reviews.llvm.org/D17665
>
> Files:
>   test/ELF/aarch64-gnu-ifunc-nosym.s
>   test/ELF/gnu-ifunc-nosym-i386.s
>   test/ELF/gnu-ifunc-nosym.s
>   test/ELF/plt.s
>
> Index: test/ELF/plt.s
> ===================================================================
> --- test/ELF/plt.s
> +++ test/ELF/plt.s
> @@ -109,7 +109,7 @@
>  // DISASM2-NEXT:  11040:  ff 25 da 1f 00 00   jmpq *8154(%rip)
>  // DISASM2-NEXT:  11046:  68 01 00 00 00      pushq $1
>  // DISASM2-NEXT:  1104b:  e9 d0 ff ff ff      jmp -48 <.plt>
> -// DISASM2-NEXT-NOT: 110C0
> +// DISASM2-NOT: 110C0
>
>  .global _start
>  _start:
> Index: test/ELF/gnu-ifunc-nosym.s
> ===================================================================
> --- test/ELF/gnu-ifunc-nosym.s
> +++ test/ELF/gnu-ifunc-nosym.s
> @@ -6,8 +6,8 @@
>  // Check that no __rela_iplt_end/__rela_iplt_start
>  // appear in symtab if there is no references to them.
>  // CHECK:      Symbols [
> -// CHECK-NEXT-NOT: __rela_iplt_end
> -// CHECK-NEXT-NOT: __rela_iplt_start
> +// CHECK-NOT: __rela_iplt_end
> +// CHECK-NOT: __rela_iplt_start
>  // CHECK: ]
>
>  .text
> Index: test/ELF/gnu-ifunc-nosym-i386.s
> ===================================================================
> --- test/ELF/gnu-ifunc-nosym-i386.s
> +++ test/ELF/gnu-ifunc-nosym-i386.s
> @@ -6,8 +6,8 @@
>  // Check that no __rel_iplt_end/__rel_iplt_start
>  // appear in symtab if there is no references to them.
>  // CHECK:      Symbols [
> -// CHECK-NEXT-NOT: __rel_iplt_end
> -// CHECK-NEXT-NOT: __rel_iplt_start
> +// CHECK-NOT: __rel_iplt_end
> +// CHECK-NOT: __rel_iplt_start
>  // CHECK: ]
>
>  .text
> Index: test/ELF/aarch64-gnu-ifunc-nosym.s
> ===================================================================
> --- test/ELF/aarch64-gnu-ifunc-nosym.s
> +++ test/ELF/aarch64-gnu-ifunc-nosym.s
> @@ -6,8 +6,8 @@
>  // Check that no __rela_iplt_end/__rela_iplt_start
>  // appear in symtab if there is no references to them.
>  // CHECK:      Symbols [
> -// CHECK-NEXT-NOT: __rela_iplt_end
> -// CHECK-NEXT-NOT: __rela_iplt_start
> +// CHECK-NOT: __rela_iplt_end
> +// CHECK-NOT: __rela_iplt_start
>  // CHECK: ]
>
>  .text
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160227/6eeb0f56/attachment.html>


More information about the llvm-commits mailing list