<p dir="ltr">Lgtm</p>
<div class="gmail_quote">On Feb 26, 2016 7:32 PM, "Paul Robinson" <<a href="mailto:Paul_Robinson@playstation.sony.com">Paul_Robinson@playstation.sony.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">probinson created this revision.<br>
probinson added a reviewer: grimar.<br>
probinson added subscribers: rafael, llvm-commits.<br>
<br>
FileCheck does not support combined suffixes.<br>
<br>
<a href="http://reviews.llvm.org/D17665" rel="noreferrer" target="_blank">http://reviews.llvm.org/D17665</a><br>
<br>
Files:<br>
test/ELF/aarch64-gnu-ifunc-nosym.s<br>
test/ELF/gnu-ifunc-nosym-i386.s<br>
test/ELF/gnu-ifunc-nosym.s<br>
test/ELF/plt.s<br>
<br>
Index: test/ELF/plt.s<br>
===================================================================<br>
--- test/ELF/plt.s<br>
+++ test/ELF/plt.s<br>
@@ -109,7 +109,7 @@<br>
// DISASM2-NEXT: 11040: ff 25 da 1f 00 00 jmpq *8154(%rip)<br>
// DISASM2-NEXT: 11046: 68 01 00 00 00 pushq $1<br>
// DISASM2-NEXT: 1104b: e9 d0 ff ff ff jmp -48 <.plt><br>
-// DISASM2-NEXT-NOT: 110C0<br>
+// DISASM2-NOT: 110C0<br>
<br>
.global _start<br>
_start:<br>
Index: test/ELF/gnu-ifunc-nosym.s<br>
===================================================================<br>
--- test/ELF/gnu-ifunc-nosym.s<br>
+++ test/ELF/gnu-ifunc-nosym.s<br>
@@ -6,8 +6,8 @@<br>
// Check that no __rela_iplt_end/__rela_iplt_start<br>
// appear in symtab if there is no references to them.<br>
// CHECK: Symbols [<br>
-// CHECK-NEXT-NOT: __rela_iplt_end<br>
-// CHECK-NEXT-NOT: __rela_iplt_start<br>
+// CHECK-NOT: __rela_iplt_end<br>
+// CHECK-NOT: __rela_iplt_start<br>
// CHECK: ]<br>
<br>
.text<br>
Index: test/ELF/gnu-ifunc-nosym-i386.s<br>
===================================================================<br>
--- test/ELF/gnu-ifunc-nosym-i386.s<br>
+++ test/ELF/gnu-ifunc-nosym-i386.s<br>
@@ -6,8 +6,8 @@<br>
// Check that no __rel_iplt_end/__rel_iplt_start<br>
// appear in symtab if there is no references to them.<br>
// CHECK: Symbols [<br>
-// CHECK-NEXT-NOT: __rel_iplt_end<br>
-// CHECK-NEXT-NOT: __rel_iplt_start<br>
+// CHECK-NOT: __rel_iplt_end<br>
+// CHECK-NOT: __rel_iplt_start<br>
// CHECK: ]<br>
<br>
.text<br>
Index: test/ELF/aarch64-gnu-ifunc-nosym.s<br>
===================================================================<br>
--- test/ELF/aarch64-gnu-ifunc-nosym.s<br>
+++ test/ELF/aarch64-gnu-ifunc-nosym.s<br>
@@ -6,8 +6,8 @@<br>
// Check that no __rela_iplt_end/__rela_iplt_start<br>
// appear in symtab if there is no references to them.<br>
// CHECK: Symbols [<br>
-// CHECK-NEXT-NOT: __rela_iplt_end<br>
-// CHECK-NEXT-NOT: __rela_iplt_start<br>
+// CHECK-NOT: __rela_iplt_end<br>
+// CHECK-NOT: __rela_iplt_start<br>
// CHECK: ]<br>
<br>
.text<br>
<br>
<br>
</blockquote></div>