[PATCH] D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files

[Michael Spencer via llvm-commits]

Bigcheese added inline comments.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:47
@@ -46,1 +46,3 @@
 
+#define DEFINE_ELF_TYPES                                                       \
+  typedef ELFFile<ELFT> ELFO;                                                  \
----------------
I would prefer this as:

#define TYPEDEF_ELF_TYPES(ELFT) ...

So that it's clear that it's a typedef and what it depends on.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:272
@@ +271,3 @@
+    Field &operator=(StringRef S) {
+      this->Str = S;
+      return *this;
----------------
Don't need this->


Repository:
  rL LLVM

http://reviews.llvm.org/D17523