[PATCH] D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files

[Eric Christopher via llvm-commits]

echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

A few inline comments to separate out some seemingly inconsequential changes. Otherwise the general idea seems fine, I haven't looked deeply at it, but a quick glance seemed like it was ok.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:523
@@ -459,3 +522,3 @@
                                             const Elf_Sym *symb,
-                                            bool &IsDefault) {
+                                            bool &IsDefault) const {
   // This is a dynamic symbol. Look in the GNU symbol version table.
----------------
Can you do this separately?

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:572
@@ -508,3 +571,3 @@
                                                StringRef StrTable,
-                                               bool IsDynamic) {
+                                               bool IsDynamic) const {
   StringRef SymbolName = unwrapOrError(Symbol->getName(StrTable));
----------------
Can you do this separately?

================
Comment at: tools/llvm-readobj/StreamWriter.h:62
@@ -61,3 +61,3 @@
 raw_ostream &operator<<(raw_ostream &OS, const HexNumber& Value);
-const std::string to_hexString(uint64_t Value, bool UpperCase = true);
+const std::string to_hexString(uint64_t Value, bool UpperCase = false);
 const std::string to_string(uint64_t Value);
----------------
Can you make this change separately?


Repository:
  rL LLVM

http://reviews.llvm.org/D17523