[PATCH] D17433: [ARM] fix initialization of PredictableSelectIsExpensive

[James Molloy via llvm-commits]

I agree that sounds like a sensible default, as long as that default can be easily overridden (I haven't looked at the code).

James

> On 23 Feb 2016, at 07:44, Junmo Park <junmoz.park at samsung.com> wrote:
>
> flyingforyou added a comment.
>
> Thanks for comment James.
>
>  // Prefer likely predicted branches to selects on out-of-order cores.
>  PredictableSelectIsExpensive = Subtarget->isLikeA9();
>
> I think if we believe `PredictableSelectIsExpensive ` is proper for out-of-order cores, we can set this by `Subtarget->getSchedModel().isOutOfOrder()`.
> And if some OoO cores have to set this false due to some regressions or whatever reasons, then we can add some code setting false for specific cores.
>
> Junmo.
>
>
> http://reviews.llvm.org/D17433
>
>
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.