[PATCH] D17433: [ARM] fix initialization of PredictableSelectIsExpensive

Junmo Park via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 23:44:25 PST 2016


flyingforyou added a comment.

Thanks for comment James.

  // Prefer likely predicted branches to selects on out-of-order cores.
  PredictableSelectIsExpensive = Subtarget->isLikeA9();

I think if we believe `PredictableSelectIsExpensive ` is proper for out-of-order cores, we can set this by `Subtarget->getSchedModel().isOutOfOrder()`.
And if some OoO cores have to set this false due to some regressions or whatever reasons, then we can add some code setting false for specific cores.

Junmo.


http://reviews.llvm.org/D17433





More information about the llvm-commits mailing list