[llvm] r261504 - CodeGen: MachineInstr::getIterator() => getInstrIterator(), NFC

[Duncan P. N. Exon Smith via llvm-commits]

+andya

> On 2016-Feb-21, at 14:58, Duncan P. N. Exon Smith via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> There was one call I updated that looked fishy, but it wasn't clear what
> the right answer was.  This was in X86FrameLowering::inlineStackProbe(),
> added in r252578 in lib/Target/X86/X86FrameLowering.cpp.  I opted to
> leave the behaviour unchanged, but I'll reply to the original commit on
> the list in a moment.

[...]

> Modified: llvm/trunk/lib/Target/X86/X86FrameLowering.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FrameLowering.cpp?rev=261504&r1=261503&r2=261504&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86FrameLowering.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86FrameLowering.cpp Sun Feb 21 16:58:35 2016
> @@ -462,7 +462,9 @@ void X86FrameLowering::inlineStackProbe(
>   }
> 
>   if (ChkStkStub != nullptr) {
> -    MachineBasicBlock::iterator MBBI = std::next(ChkStkStub->getIterator());
> +    // FIXME: MBBI is a bundle iterator.  Should this be getBundleIterator()?
> +    MachineBasicBlock::iterator MBBI =
> +        std::next(ChkStkStub->getInstrIterator());

^ This is what looks fishy to me.

>     assert(std::prev(MBBI).operator==(ChkStkStub) &&
>       "MBBI expected after __chkstk_stub.");
>     DebugLoc DL = PrologMBB.findDebugLoc(MBBI);
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits