[PATCH] D17090: Identify cpu family 6 and model 94 as "skl" in getHostCPUName

[David Kreitzer via llvm-commits]

DavidKreitzer added inline comments.

================
Comment at: lib/Support/Host.cpp:378
@@ -378,1 +377,3 @@
+      case 94:
+        return "skl";
 
----------------
sanjoy wrote:
> DavidKreitzer wrote:
> > See http://reviews.llvm.org/D16756.
> > 
> > You probably want to replace "skylake" with "skylake-avx512" and "skl" with "skylake" to be consistent with the naming scheme gcc is using for the -march switch.
> > 
> You mean replace `"skl"` with `"skylake"` everywhere?  Won't that break clang (as of today) since today by `"skylake"` it means Skylake Server?  Or does clang not have to agree with LLVM on these names?
> 
Right, I'm suggesting replacing "skl" with "skylake" everywhere and "skylake" with "skylake-avx512" everywhere (both in LLVM and in clang) to be consistent with gcc. I admit that might be beyond what you are trying to do in this change set, though.

I think you are correctly classifying the model 94 CPU as SkylakeClient, but without accompanying changes in clang to actually support a "skl" target (like Elena is doing in http://reviews.llvm.org/D16756.), won't this cause problems for clang? What happens if you run "clang -march=native" with this change on your SkylakeClient machine?



http://reviews.llvm.org/D17090