[PATCH] D17090: Identify cpu family 6 and model 94 as "skl" in getHostCPUName
Sanjoy Das via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 11 15:31:46 PST 2016
sanjoy added inline comments.
================
Comment at: lib/Support/Host.cpp:378
@@ -378,1 +377,3 @@
+ case 94:
+ return "skl";
----------------
DavidKreitzer wrote:
> See http://reviews.llvm.org/D16756.
>
> You probably want to replace "skylake" with "skylake-avx512" and "skl" with "skylake" to be consistent with the naming scheme gcc is using for the -march switch.
>
You mean replace `"skl"` with `"skylake"` everywhere? Won't that break clang (as of today) since today by `"skylake"` it means Skylake Server? Or does clang not have to agree with LLVM on these names?
http://reviews.llvm.org/D17090
More information about the llvm-commits
mailing list