[PATCH] Introduce llvm/ADT/OptionSet.h utility class

[Chandler Carruth via llvm-commits]

On Fri, Feb 12, 2016 at 1:05 PM Argyrios Kyrtzidis <kyrtzidis at apple.com>
wrote:

> On Feb 12, 2016, at 11:38 AM, Chandler Carruth <chandlerc at gmail.com>
> wrote:
>
> On Fri, Feb 12, 2016 at 11:32 AM Argyrios Kyrtzidis <kyrtzidis at apple.com>
> wrote:
>
>> On Feb 12, 2016, at 11:23 AM, Philip Reames <listmail at philipreames.com>
>> wrote:
>>
>> Er, if this didn't get reviewed, please revert it.  This is not merely
>> poor form, but unacceptable for non-trivial changes in areas for which you
>> are not a regular contributor.
>>
>>
>> + Chandler, who is listed as ADT owner. I’d like to get his opinion if
>> this needs to be reverted.
>>
>
> It isn't up to the owner of ADT to decide whether this needs to be
> reverted. All I can do in that capacity is help you find a reviewer.
>
> The community as a whole gets to say whether it needs to be reverted, and
> I think Philip has made a clear point here (which I completely agree with)
> and so I think you should probably revert. =]
>
>
>
>>
>>
>> In particular, moving code between the swift repo and the LLVM repo is
>> not necessarily OK.  At minimum, there needs to be some discussion on
>> llvm-dev of the licensing and implications.  Specifically, with the
>> possible relicensing being discussed, adding a bunch of unknown external
>> authors (even if the current license is compatible) might not be a good
>> idea.
>>
>>
>> I got permission internally and contributed the header under the LLVM
>> license, I don’t think that whether it originated from swift repo or not
>> makes any difference here.
>> If you could elaborate more on your concerns it would be helpful.
>>
>
> How do we know whether any other contributor to Swift authored some of the
> code in this file? Does Apple get copyright assignment for all Swift
> contributions? Only if Apple has copyright assignment for all contributions
> to Swift or only people from Apple have every contributed to this part of
> Swift is asking internally enough.
>
> And since this is an open source project, it would seem polite (even if
> not necessary) to also ask the community rather than just asking
> internally. We don't all work at Apple. =/
>
>
> + Chris, for comment.
>

Also, just to be clear (since I think my original email wasn't terribly): I
think something as simple as this code review thread would have been fine
if you had waited for the code review, and made it clear why it was OK to
contribute (only Apple folks have touched it, or whatever).

I'm not suggesting we need to have some big or complex discussion. =] We
have plenty of those on harder subjects.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160212/ecf4600d/attachment.html>