<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Fri, Feb 12, 2016 at 1:05 PM Argyrios Kyrtzidis <<a href="mailto:kyrtzidis@apple.com">kyrtzidis@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><blockquote type="cite"><div>On Feb 12, 2016, at 11:38 AM, Chandler Carruth <<a href="mailto:chandlerc@gmail.com" target="_blank">chandlerc@gmail.com</a>> wrote:</div><br></blockquote></div></div><div style="word-wrap:break-word"><div><blockquote type="cite"><div><div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Fri, Feb 12, 2016 at 11:32 AM Argyrios Kyrtzidis <<a href="mailto:kyrtzidis@apple.com" target="_blank">kyrtzidis@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><blockquote type="cite"><div>On Feb 12, 2016, at 11:23 AM, Philip Reames <<a href="mailto:listmail@philipreames.com" target="_blank">listmail@philipreames.com</a>> wrote:</div><br><div>
<div text="#000000" bgcolor="#FFFFFF">
Er, if this didn't get reviewed, please revert it. This is not
merely poor form, but unacceptable for non-trivial changes in areas
for which you are not a regular contributor. <br></div></div></blockquote><div><br></div></div></div><div style="word-wrap:break-word"><div><div>+ Chandler, who is listed as ADT owner. I’d like to get his opinion if this needs to be reverted.</div></div></div></blockquote><div><br></div><div>It isn't up to the owner of ADT to decide whether this needs to be reverted. All I can do in that capacity is help you find a reviewer.</div><div><br></div><div>The community as a whole gets to say whether it needs to be reverted, and I think Philip has made a clear point here (which I completely agree with) and so I think you should probably revert. =]</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><br><blockquote type="cite"><div><div text="#000000" bgcolor="#FFFFFF">
<br>
In particular, moving code between the swift repo and the LLVM repo
is not necessarily OK. At minimum, there needs to be some
discussion on llvm-dev of the licensing and implications.
Specifically, with the possible relicensing being discussed, adding
a bunch of unknown external authors (even if the current license is
compatible) might not be a good idea.<br></div></div></blockquote><div><br></div></div></div><div style="word-wrap:break-word"><div><div>I got permission internally and contributed the header under the LLVM license, I don’t think that whether it originated from swift repo or not makes any difference here.</div><div>If you could elaborate more on your concerns it would be helpful.</div></div></div></blockquote><div><br></div><div>How do we know whether any other contributor to Swift authored some of the code in this file? Does Apple get copyright assignment for all Swift contributions? Only if Apple has copyright assignment for all contributions to Swift or only people from Apple have every contributed to this part of Swift is asking internally enough.</div><div><br></div><div>And since this is an open source project, it would seem polite (even if not necessary) to also ask the community rather than just asking internally. We don't all work at Apple. =/</div></div></div></div></blockquote></div></div><div style="word-wrap:break-word"><div><blockquote type="cite"></blockquote><div><br></div><div>+ Chris, for comment.</div></div></div></blockquote><div><br></div><div>Also, just to be clear (since I think my original email wasn't terribly): I think something as simple as this code review thread would have been fine if you had waited for the code review, and made it clear why it was OK to contribute (only Apple folks have touched it, or whatever).</div><div><br></div><div>I'm not suggesting we need to have some big or complex discussion. =] We have plenty of those on harder subjects.</div></div></div>