[PATCH] D17173: [X86] Update test cases that would be affected when X86FixupBWInsts is turned on.

[Sanjay Patel via llvm-commits]

spatel added a comment.

This feels similar to http://reviews.llvm.org/D12656, and I don't think it's the right choice for the same reasons that were cited in that review.

I'd prefer that we just change the checks in these tests as part of flipping/removing the "-fixup-byte-word-insts" switch. Alternatively, we could add another RUN to these tests to show the exact codegen difference produced by -fixup-byte-word-insts for these cases.

Masking the default output could hide codegen differences that we would actually like to observe. As an example, we may want to limit the FixupBW pass based on micro-arch (should an in-order CPU get the same set of transforms as as OoO?). If that happens, then these tests become more important as verification that the default behavior is not changing.


http://reviews.llvm.org/D17173