[PATCH] D17039: AMDGPU: Set flat_scratch from flat_scratch_init reg

[Matt Arsenault via llvm-commits]

arsenm closed this revision.
arsenm added a comment.

r260658


================
Comment at: lib/Target/AMDGPU/SIFrameLowering.cpp:78
@@ -86,1 +77,3 @@
 
+  if (MFI->hasFlatScratchInit() /*&& MFI->hasFlatInstructions()*/) {
+    // We don't need this if we only have spills since there is no user facing
----------------
tstellarAMD wrote:
> I'm not sure if this comment was intentional, but I think this should be dropped.
The condition should be there, but right now it doesn't do anything because flat instructions are detected in SILowerControlFlow


http://reviews.llvm.org/D17039