[PATCH] D17039: AMDGPU: Set flat_scratch from flat_scratch_init reg

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 18:03:10 PST 2016


tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: lib/Target/AMDGPU/SIFrameLowering.cpp:78
@@ -86,1 +77,3 @@
 
+  if (MFI->hasFlatScratchInit() /*&& MFI->hasFlatInstructions()*/) {
+    // We don't need this if we only have spills since there is no user facing
----------------
I'm not sure if this comment was intentional, but I think this should be dropped.


http://reviews.llvm.org/D17039





More information about the llvm-commits mailing list