[PATCH] D17000: [AArch64] Reduce number of callee-save save/restores.
Geoff Berry via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 11 12:58:00 PST 2016
gberry marked 2 inline comments as done.
================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:757
@@ +756,3 @@
+ RegPairInfo &LastPair = RegPairs.back();
+ assert(AFI->getCalleeSavedStackSize() % 8 == 0);
+ LastPair.Offset = AFI->getCalleeSavedStackSize() / 8;
----------------
Not currently, no. Maybe in a future change that combines the callee-save stack bump with the local variable stack bump.
================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:1001
@@ +1000,3 @@
+ // store the pair.
+ if (Subtarget.isTargetMachO())
+ SavedRegs.set(UnspilledCSGPRPaired);
----------------
Good catch. I just recalculated NumRegsSpilled at the end here so SavedRegs is always the canonical representation.
http://reviews.llvm.org/D17000
More information about the llvm-commits
mailing list