[PATCH] D17160: AMDGPU/SI: Add llvm.amdgcn.mov.dpp intrinsic

[Matt Arsenault via llvm-commits]

arsenm added inline comments.

================
Comment at: include/llvm/IR/IntrinsicsAMDGPU.td:198-200
@@ +197,5 @@
+
+// VI Only
+// llvm.amdgcn.mov.dpp.i32 <src> <dpp_ctrl> <bound_ctrl> <bank_mask> <row_mask>
+def int_amdgcn_mov_dpp :
+  Intrinsic<[llvm_anyint_ty],
----------------
I was keeping VI only intrinsics somewhere near the bottom of the file. There should already be a VI only comment.

I've been meaning to clean this up to make it more obvious

================
Comment at: include/llvm/IR/IntrinsicsAMDGPU.td:201
@@ +200,3 @@
+def int_amdgcn_mov_dpp :
+  Intrinsic<[llvm_anyint_ty],
+            [LLVMMatchType<0>, llvm_i32_ty, llvm_i1_ty, llvm_i32_ty,
----------------
Is this for i16/i32? I don't think there are any VOP2 i64 instructions

================
Comment at: include/llvm/IR/IntrinsicsAMDGPU.td:203
@@ +202,3 @@
+            [LLVMMatchType<0>, llvm_i32_ty, llvm_i1_ty, llvm_i32_ty,
+             llvm_i32_ty], [IntrNoMem]>;
+
----------------
I think this needs to be convergent


http://reviews.llvm.org/D17160