[llvm] r260280 - Fix a test added in r260263

[JF Bastien via llvm-commits]

On Wed, Feb 10, 2016 at 9:32 AM, Ehsan Akhgari <ehsan.akhgari at gmail.com>
wrote:

> On Wed, Feb 10, 2016 at 11:24 AM, JF Bastien <jfb at chromium.org> wrote:
>
>> Hi Ehsan,
>>
>> This test still seems broken when LLVM is built with:
>> -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON
>>
>> In that case the following occurs:
>> ./bin/llvm-config --libs
>> -lLLVM-3.9svn
>>
>> Correspondingly:
>> ./bin/llvm-config --shared-mode
>> shared
>>
>> Could you please fix or disable the test?
>>
>
> Hmm, when I try to build with those flags, llvm-config's output changes in
> a way that I can't really describe.  When it is piped to something (for
> example when running ./bin/llvm-config --libs 2>&1 | cat), the end point of
> the pipe never receives anything on its stdin.  So FileCheck fails with
> errors like "FileCheck error: '-' is empty.".  Also ./bin/llvm-config
> --shared-mode prints static, since it seems like that depends on
> BUILD_SHARED_LIBS, and when I turn that on cmake fails like this:
>
> ...
> -- OSX 10.4 supported arches: i386;x86_64;x86_64h
> -- Compiler-RT supported architectures: i386;x86_64
> -- Clang version: 3.9.0
> -- LLD version: 3.9.0
> CMake Error at tools/llvm-shlib/CMakeLists.txt:43 (list):
>   list sub-command REMOVE_DUPLICATES requires list to be present.
>
> I suspect that your build configuration is a bit more involved.  I would
> appreciate if you could share more information about how you build so that
> I can reproduce your build and fix the tests accordingly.
>
> At any rate, since I'm about to leave on vacation I will disable these
> tests for now, and will look into fixing them again in about 10 days...
> Sorry for the inconvenience.
>

Thanks for the fix. It sounds like llvm-config isn't very good at
describing dylib configurations!

The failing bot builds with:

      cmake -G Ninja $LLVM_SRC_DIR \
       -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
       -DLLVM_BUILD_TESTS=ON \
       -DCMAKE_C_COMPILER=$CC \
       -DCMAKE_CXX_COMPILER=$CXX \
       -DCMAKE_BUILD_TYPE=Release \
       -DCMAKE_INSTALL_PREFIX=$INSTALL_DIR \
       -DLLVM_BUILD_LLVM_DYLIB=ON \
       -DLLVM_LINK_LLVM_DYLIB=ON \
       -DLLVM_INSTALL_TOOLCHAIN_ONLY=ON \
       -DLLVM_ENABLE_ASSERTIONS=ON


Cheers,
> Ehsan
>
>
>> Thanks,
>>
>> JF
>>
>> On Tue, Feb 9, 2016 at 1:10 PM, Ehsan Akhgari via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>> Author: ehsan
>>> Date: Tue Feb  9 15:10:22 2016
>>> New Revision: 260280
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=260280&view=rev
>>> Log:
>>> Fix a test added in r260263
>>>
>>> Modified:
>>>     llvm/trunk/test/tools/llvm-config/libs.test
>>>
>>> Modified: llvm/trunk/test/tools/llvm-config/libs.test
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-config/libs.test?rev=260280&r1=260279&r2=260280&view=diff
>>>
>>> ==============================================================================
>>> --- llvm/trunk/test/tools/llvm-config/libs.test (original)
>>> +++ llvm/trunk/test/tools/llvm-config/libs.test Tue Feb  9 15:10:22 2016
>>> @@ -1,4 +1,4 @@
>>> -RUN: llvm-config --libs core 2>&1 | FileCheck %s
>>> +RUN: llvm-config --libs core support 2>&1 | FileCheck %s
>>>  CHECK: LLVMCore
>>>  CHECK: LLVMSupport
>>>  CHECK-NOT: error
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
>>
>
>
> --
> Ehsan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160210/5f0c0142/attachment-0001.html>