<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Feb 10, 2016 at 9:32 AM, Ehsan Akhgari <span dir="ltr"><<a href="mailto:ehsan.akhgari@gmail.com" target="_blank">ehsan.akhgari@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="">On Wed, Feb 10, 2016 at 11:24 AM, JF Bastien <span dir="ltr"><<a href="mailto:jfb@chromium.org" target="_blank">jfb@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Ehsan,<div><br></div><div>This test still seems broken when LLVM is built with: -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON</div><div><br></div><div>In that case the following occurs:</div><div><div>./bin/llvm-config --libs</div><div>-lLLVM-3.9svn</div></div><div><br></div><div>Correspondingly:</div><div><div>./bin/llvm-config --shared-mode</div><div>shared</div></div><div><br></div><div>Could you please fix or disable the test?</div></div></blockquote><div><br></div></span><div>Hmm, when I try to build with those flags, llvm-config's output changes in a way that I can't really describe. When it is piped to something (for example when running ./bin/llvm-config --libs 2>&1 | cat), the end point of the pipe never receives anything on its stdin. So FileCheck fails with errors like "FileCheck error: '-' is empty.". Also ./bin/llvm-config --shared-mode prints static, since it seems like that depends on BUILD_SHARED_LIBS, and when I turn that on cmake fails like this:<br><br>...<br>-- OSX 10.4 supported arches: i386;x86_64;x86_64h<br>-- Compiler-RT supported architectures: i386;x86_64<br>-- Clang version: 3.9.0<br>-- LLD version: 3.9.0<br>CMake Error at tools/llvm-shlib/CMakeLists.txt:43 (list):<br> list sub-command REMOVE_DUPLICATES requires list to be present.<br><br></div><div>I suspect that your build configuration is a bit more involved. I would appreciate if you could share more information about how you build so that I can reproduce your build and fix the tests accordingly.<br><br></div><div>At any rate, since I'm about to leave on vacation I will disable these tests for now, and will look into fixing them again in about 10 days... Sorry for the inconvenience.<br></div></div></div></div></blockquote><div><br></div><div>Thanks for the fix. It sounds like llvm-config isn't very good at describing dylib configurations!</div><div><br></div><div>The failing bot builds with:</div><div><br></div><div><div> cmake -G Ninja $LLVM_SRC_DIR \</div><div> -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \</div><div> -DLLVM_BUILD_TESTS=ON \</div><div> -DCMAKE_C_COMPILER=$CC \</div><div> -DCMAKE_CXX_COMPILER=$CXX \</div><div> -DCMAKE_BUILD_TYPE=Release \</div><div> -DCMAKE_INSTALL_PREFIX=$INSTALL_DIR \</div><div> -DLLVM_BUILD_LLVM_DYLIB=ON \</div><div> -DLLVM_LINK_LLVM_DYLIB=ON \</div><div> -DLLVM_INSTALL_TOOLCHAIN_ONLY=ON \</div><div> -DLLVM_ENABLE_ASSERTIONS=ON</div></div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Cheers,<br></div><div>Ehsan<br></div><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Thanks,</div><div><br></div><div>JF</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 9, 2016 at 1:10 PM, Ehsan Akhgari via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Author: ehsan<br>
Date: Tue Feb 9 15:10:22 2016<br>
New Revision: 260280<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=260280&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=260280&view=rev</a><br>
Log:<br>
Fix a test added in r260263<br>
<br>
Modified:<br>
llvm/trunk/test/tools/llvm-config/libs.test<br>
<br>
Modified: llvm/trunk/test/tools/llvm-config/libs.test<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-config/libs.test?rev=260280&r1=260279&r2=260280&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-config/libs.test?rev=260280&r1=260279&r2=260280&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/tools/llvm-config/libs.test (original)<br>
+++ llvm/trunk/test/tools/llvm-config/libs.test Tue Feb 9 15:10:22 2016<br>
@@ -1,4 +1,4 @@<br>
-RUN: llvm-config --libs core 2>&1 | FileCheck %s<br>
+RUN: llvm-config --libs core support 2>&1 | FileCheck %s<br>
CHECK: LLVMCore<br>
CHECK: LLVMSupport<br>
CHECK-NOT: error<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</blockquote></div></div></div><span class=""><font color="#888888"><br><br clear="all"><br>-- <br><div><div dir="ltr">Ehsan<br></div></div>
</font></span></div></div>
</blockquote></div><br></div></div>