[PATCH] D17028: [ThinLTO] Use MD5 hash in function index.

[Teresa Johnson via llvm-commits]

On Wed, Feb 10, 2016 at 9:55 AM, Mehdi Amini <mehdi.amini at apple.com> wrote:

>
> > On Feb 10, 2016, at 9:53 AM, Teresa Johnson <tejohnson at google.com>
> wrote:
> >
> > tejohnson added inline comments.
> >
> > ================
> > Comment at: test/tools/gold/X86/thinlto.ll:27-31
> > @@ -26,5 +26,7 @@
> > ; COMBINED-NEXT: <VALUE_SYMTAB
> > -; COMBINED-NEXT: <COMBINED_FNENTRY {{.*}} record string = '{{f|g}}'
> > -; COMBINED-NEXT: <COMBINED_FNENTRY {{.*}} record string = '{{f|g}}'
> > +; Check that the format is: op0=offset, op1=funcguid, where funcguid is
> > +; the lower 64 bits of the function name MD5.
> > +; COMBINED-NEXT: <COMBINED_FNENTRY abbrevid={{[0-9]+}} op0={{[0-9]+}}
> op1={{-3706093650706652785|-5300342847281564238}}
> > +; COMBINED-NEXT: <COMBINED_FNENTRY abbrevid={{[0-9]+}} op0={{[0-9]+}}
> op1={{-3706093650706652785|-5300342847281564238}}
> > ; COMBINED-NEXT: </VALUE_SYMTAB
> >
> > ----------------
> > I think that's what I have here already? I could shorten this a bit by
> replacing the intermediate parts with {{.*}}. E.g.:
> >
> > ; COMBINED-NEXT: <COMBINED_FNENTRY {{.*}}
> {{-3706093650706652785|-5300342847281564238}}
> >
> > Is that preferable?
>
> I have no preference, but it would be nice having a comment above saying
> it is the hash that you are matching here.
>

I already added that comment (see the snippet above).


>
> --
> Mehdi
>
>


-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |  408-460-2413
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160210/4ec6af46/attachment.html>