<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 10, 2016 at 9:55 AM, Mehdi Amini <span dir="ltr"><<a href="mailto:mehdi.amini@apple.com" target="_blank">mehdi.amini@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
> On Feb 10, 2016, at 9:53 AM, Teresa Johnson <<a href="mailto:tejohnson@google.com">tejohnson@google.com</a>> wrote:<br>
><br>
> tejohnson added inline comments.<br>
><br>
> ================<br>
> Comment at: test/tools/gold/X86/thinlto.ll:27-31<br>
> @@ -26,5 +26,7 @@<br>
> ; COMBINED-NEXT: <VALUE_SYMTAB<br>
> -; COMBINED-NEXT: <COMBINED_FNENTRY {{.*}} record string = '{{f|g}}'<br>
> -; COMBINED-NEXT: <COMBINED_FNENTRY {{.*}} record string = '{{f|g}}'<br>
> +; Check that the format is: op0=offset, op1=funcguid, where funcguid is<br>
> +; the lower 64 bits of the function name MD5.<br>
> +; COMBINED-NEXT: <COMBINED_FNENTRY abbrevid={{[0-9]+}} op0={{[0-9]+}} op1={{-3706093650706652785|-5300342847281564238}}<br>
> +; COMBINED-NEXT: <COMBINED_FNENTRY abbrevid={{[0-9]+}} op0={{[0-9]+}} op1={{-3706093650706652785|-5300342847281564238}}<br>
> ; COMBINED-NEXT: </VALUE_SYMTAB<br>
><br>
> ----------------<br>
> I think that's what I have here already? I could shorten this a bit by replacing the intermediate parts with {{.*}}. E.g.:<br>
><br>
> ; COMBINED-NEXT: <COMBINED_FNENTRY {{.*}} {{-3706093650706652785|-5300342847281564238}}<br>
><br>
> Is that preferable?<br>
<br>
</span>I have no preference, but it would be nice having a comment above saying it is the hash that you are matching here.<br></blockquote><div><br></div><div>I already added that comment (see the snippet above).</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Mehdi<br>
<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 408-460-2413</td></tr></tbody></table></span></div>
</div></div>