[PATCH] D16931: [codeview] Describe int local variables using .cv_def_range

[David Blaikie via llvm-commits]

dblaikie added a comment.

I must be missing something - how does the begin/endFunction functionality that you moved into teh base class get fired for DwarfDebug? It looks like there should be a call to Base::beginFunction in DwarfDebug::beginFunction where the code was moved from?


================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:569
@@ +568,3 @@
+  OS.AddComment("TypeIndex");
+  OS.EmitIntValue(TypeIndex::Int32().getIndex(), 4);
+  OS.AddComment("Flags");
----------------
Some comments here might not go astray (what is the format of these records you're emitting (maybe a broad comment at the top describing the format overall, then details on each field))

Specifically I don't know what the 4 here and 2, below (flags), are.


http://reviews.llvm.org/D16931