[PATCH] D16931: [codeview] Describe int local variables using .cv_def_range

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 14:52:42 PST 2016


rnk added a comment.

Eric wanted to be CC'd, and David asked "why inheritance not composition". I could potentially see making a separate class that is specifically responsible for inserting labels before and after dbg value ranges, but I suspect I'll want to factor more stuff out of DwarfDebug and into here as time goes on. In particular, findPrologueEnd is currently duplicated. Using a base class also allows me to make most of these members protected, making it clear that they aren't intended for use by any other clients.


http://reviews.llvm.org/D16931





More information about the llvm-commits mailing list