[PATCH] D16383: Change ConstantFoldInstOperands to take Instruction instead of opcode and type. NFC.

[Manuel Jacob via llvm-commits]

On 2016-02-09 22:28, Daniel Berlin wrote:
> Hey Manuel,
> Will you have time to address these issues?

Sorry for the delay.  I'm currently busy with exam preparation and 
forgot about this after having started to write answers and leaving them 
in my draft folder...

I'll answer all questions in this review thread today and, unless we 
agree otherwise, submit a patch re-adding the removed interface.

-Manuel

> If not, i'm tempted to revert this set of changes.
> While I agree with your end goals of supporting the pointer type 
> changes,,
> right now i see unaddressed issues with this particular implementation
> As I'm sure you know, comments and issues in reviews after commit need 
> to
> be addressed the same as pre-commit reviews and it's been about 2 
> weeks.
> .
> So if you won't have time to tackle this, that's fine, but we should 
> just
> probably revert it until you (or someone else) does have the time to 
> tackle
> this :)
> 
> --Dan